Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper command for finding items with invalid times #729

Open
jisantuc opened this issue May 12, 2021 · 0 comments
Open

Add helper command for finding items with invalid times #729

jisantuc opened this issue May 12, 2021 · 0 comments

Comments

@jisantuc
Copy link
Contributor

Improvement

After #728, it's possible users will have items that were previously valid / decodeable that have become invalid / un-decodeable because items now decode the datetime / start_datetime + end_datetime fields. If those fields are all missing, or if an item has them present but they can't be decoded in any of the time formats we recognize (e.g. if the middle T is missing), Franklin will throw an exception when serializing results. That's not great! We should provide a command that users can run that identifies the items that can't be decoded and prints their ids and their current datetime, start_datetime, and end_datetime values (focused on time since that's where the breaking change occurred).

Notes + Context

I discovered this issue with some test data missing the middle T. I think RFC3339 says that the middle T is required (though it can be a t), but I get sleepy every time I start reading that spec so not certain about that 😴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant