-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Host header to build urls #951
Comments
Checking X-Forwarded-Host would be prudent as well |
Hey @shane-axiom, thanks for the issues! Just a heads up I probably won't be able to get to these until at least two weeks from now since close to 100% of my extra time right now is going toward preparing for a FOSS4G workshop I'm giving. Do you know Scala? If so I'd be happy to a review a PR that makes this change. Also feel free to drop by the Gitter channel if you run into any trouble |
No worries, I'm not blocked on these particular issues, they're more nice-to-have/best practices kind of requests. Appreciate the response and the project! |
Currently urls are built using
localhost
unless--api-host
is explicitly passed. It would be nice if franklin inspected theHost
header of incoming requests and used the value (if present) as the domain in the constructed url. This would allow a single franklin instance to be hosted under multiple domain names, among other deployment scenarios.The text was updated successfully, but these errors were encountered: