Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even on small changes e.g. one file - git-review producing extensive description on PR #56

Open
kalabiyau opened this issue Jul 25, 2013 · 2 comments

Comments

@kalabiyau
Copy link
Collaborator

  • forked from master
  • pushed PR with one commit
    PR description shows huge set of changes

@b4mboo know more about it that me, because i never took a proper look to git-review internals.

@b4mboo
Copy link
Owner

b4mboo commented Jul 25, 2013

This seems to be a bug when merging master into the feature branch. The prefilled PR description lists all the commits, which can be a bit misleading if you only have a small change in one single commit and the PR's description shows 20 (or more) commits which are already on master.

@b4mboo
Copy link
Owner

b4mboo commented Aug 30, 2013

So we need to adjust the way the description is generated and filter out commits that have already been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants