Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitbucket support #81

Open
b4mboo opened this issue Oct 7, 2013 · 3 comments
Open

Add Bitbucket support #81

b4mboo opened this issue Oct 7, 2013 · 3 comments

Comments

@b4mboo
Copy link
Owner

b4mboo commented Oct 7, 2013

Right now git-review only supports GitHub. It might however be nice to extend the functionality towards allowing other services (i.e. BitBucket).

@ghost ghost assigned tboerger Oct 7, 2013
@b4mboo
Copy link
Owner Author

b4mboo commented Oct 7, 2013

The idea is to basically create a factory pattern that adds an abstraction layer GitServer, whose instance replaces the current occurrences of the GitHub instance. Internally it should pass the requests on to the actual implementation instance. Such that a request for e.g. @git_server.open_requests would query the data from the correct server.

@b4mboo b4mboo assigned xystushi and unassigned tboerger Jul 2, 2014
@b4mboo
Copy link
Owner Author

b4mboo commented Jul 2, 2014

@xystushi is creating bucketkit to access BitBucket's API.

@b4mboo
Copy link
Owner Author

b4mboo commented Jul 8, 2014

@xystushi I just found some time to hack on git-review. There is a lot to do, but I think we're on the right path. I'm ripping the old github.rb apart and make this way more object oriented. Once this is done, extending it to BitBucket should be way easier. Take a look at my progress in the development branch and tell me what you think, if you find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants