Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve distance estimation #130

Open
nickjcroucher opened this issue Nov 20, 2020 · 2 comments
Open

Improve distance estimation #130

nickjcroucher opened this issue Nov 20, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nickjcroucher
Copy link
Collaborator

It may be worth testing whether corrections to the pairwise distances could be employed as described in https://gitlab.pasteur.fr/GIPhy/JolyTree, as we are now observing core Hamming distances >0.1; as an initial test, it could be employed in the tree visualisation, but may even be helpful in resolving within strain/between strain distances.

@nickjcroucher nickjcroucher added the enhancement New feature or request label Nov 20, 2020
@nickjcroucher nickjcroucher self-assigned this Nov 20, 2020
@johnlees
Copy link
Member

johnlees commented Nov 20, 2020

Comparing equation 3 in the paper to the current Monte Carlo method and/or using this method for drawing the tree?

@nickjcroucher
Copy link
Collaborator Author

Sorry if I was unclear - rather than correcting for false positive matches, it would be a correction for multiple substitutions occurring at the same site - this should not change small distances, but would increase larger distances (which are systematically underestimated), which might help separate within & between strain distances where Hamming distances are large. But at a simpler level, it might improve the phylogenies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants