Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for FirmwareUpdate dataformat #88

Merged
merged 12 commits into from
Mar 6, 2024
Merged

Conversation

MCLiii
Copy link
Member

@MCLiii MCLiii commented Mar 3, 2024

We should probably merge firmwareUpdate dataformat branch into main as well

@MCLiii MCLiii requested a review from jackwherry March 3, 2024 18:37
Copy link
Member

@jackwherry jackwherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this appears to work well. I've requested a few minor changes to remove some dead code and address a comment

Frontend/src/Components/Motor_Motion/Motor_Motion.js Outdated Show resolved Hide resolved
Frontend/src/Components/Motor_Motion/Motor_Motion.js Outdated Show resolved Hide resolved
Copy link
Member

@jackwherry jackwherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code issues now tracked in #89

@MCLiii
Copy link
Member Author

MCLiii commented Mar 6, 2024

Thank you Jack!

@MCLiii MCLiii merged commit df5745e into main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants