New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended standard labels in Helm charts #170

Open

JakobEdding opened this issue Jan 30, 2023 · 0 comments

Member

JakobEdding commented Jan 30, 2023 •

edited

Loading

So instead of the current labels (source)

labels:
    app: {{ template "streams-app.name" . }}
    chart: {{ template "streams-app.chart" . }}
    release: {{ .Release.Name }}
...

... we should use recommended labels as detailed in Kubernetes docs and Helm docs:

labels:
    app.kubernetes.io/name: {{ template "streams-app.name" . }}
    app.kubernetes.io/instance: {{ .Release.Name }}
    app.kubernetes.io/managed-by: {{ .Release.Service }}
    helm.sh/chart: {{ template "streams-app.chart" . }}
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment