-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error on master #43394
Fix compilation error on master #43394
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43394 +/- ##
============================================
- Coverage 77.50% 77.50% -0.01%
- Complexity 58581 58583 +2
============================================
Files 3438 3438
Lines 219214 219215 +1
Branches 28919 28919
============================================
Hits 169910 169910
- Misses 39890 39892 +2
+ Partials 9414 9413 -1 ☔ View full report in Codecov by Sentry. |
Sure.. but wondering where it was broken. I cannot see that the build is failing in the pointed PR. is it a regression issue not reflected in our tests? |
There should have been a merge conflict in #42854 but this wasn't detected by git. The pipeline ran with the previous version of master, where the |
In summary: #42854 used a variable that was removed in #42945, but since the pipeline was running with the state of the branch, where the variable still existed there was no failure. This could have been prevented by either merging master into #42854 or rebasing it onto master. |
Purpose
Fix the compilation error introduced in #42854.
There, the JsonParser object was used, which was removed with #42945
Check List