Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error on master #43394

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

Shadow-Devil
Copy link
Contributor

@Shadow-Devil Shadow-Devil commented Sep 14, 2024

Purpose

Fix the compilation error introduced in #42854.
There, the JsonParser object was used, which was removed with #42945

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Shadow-Devil
Copy link
Contributor Author

Shadow-Devil commented Sep 14, 2024

@gimantha Could you please review and merge this PR before reviewing any of my other PRs?
I fixed the compilation error introduced in #42854
and also noticed that in #43067 I made a mistake for defining the output zip file.
This is now fixed, sorry for the inconvenience.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (0477a4a) to head (1622a6f).
Report is 64 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43394      +/-   ##
============================================
- Coverage     77.50%   77.50%   -0.01%     
- Complexity    58581    58583       +2     
============================================
  Files          3438     3438              
  Lines        219214   219215       +1     
  Branches      28919    28919              
============================================
  Hits         169910   169910              
- Misses        39890    39892       +2     
+ Partials       9414     9413       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimantha
Copy link
Contributor

gimantha commented Sep 15, 2024

@gimantha Could you please review and merge this PR before reviewing any of my other PRs? I fixed the compilation error introduced in #42854 and also noticed that in #43067 I made a mistake for defining the output zip file. This is now fixed, sorry for the inconvenience.

Sure.. but wondering where it was broken. I cannot see that the build is failing in the pointed PR. is it a regression issue not reflected in our tests?

@Shadow-Devil
Copy link
Contributor Author

There should have been a merge conflict in #42854 but this wasn't detected by git. The pipeline ran with the previous version of master, where the parser variable was still defined.

@Shadow-Devil
Copy link
Contributor Author

In summary: #42854 used a variable that was removed in #42945, but since the pipeline was running with the state of the branch, where the variable still existed there was no failure. This could have been prevented by either merging master into #42854 or rebasing it onto master.
The other issue with #43067 was not noticed because the successful build steps were cached. Once this cache expired and it was executed again it threw the build failure.

@gimantha gimantha merged commit d2a0167 into ballerina-platform:master Sep 16, 2024
28 of 32 checks passed
@Shadow-Devil Shadow-Devil deleted the fix-compilation branch September 16, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants