Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a file #334

Open
payne911 opened this issue Aug 25, 2023 · 2 comments
Open

Renaming a file #334

payne911 opened this issue Aug 25, 2023 · 2 comments
Labels

Comments

@payne911
Copy link
Contributor

I'm not entirely sure, but it doesn't seem like lsp4intellij appropriately handles the case where someone renames a class which has an associated file name.
It seems to send the didChange notifications to modify the text references in different files, but it won't be able to track new changes done in that file since the textDocument key is now changed. I'm not an LSP expert, but given the file was opened in IntelliJ, shouldn't this trigger a didClose on the old file name, and a didOpen on the new one?

@nixel2007
Copy link
Contributor

@payne911
Copy link
Contributor Author

payne911 commented Oct 31, 2023

Does this library support this already?
I can only find references to textDocument/rename (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_rename), which I'm not sure if it does the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants