diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 00000000..d13affe3 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,2 @@ +# Ensure all Java files use LF. +*.java eol=lf diff --git a/.github/workflows/build-timestamped-master.yml b/.github/workflows/build-timestamped-master.yml index 0ed9f518..9dcc4ed3 100644 --- a/.github/workflows/build-timestamped-master.yml +++ b/.github/workflows/build-timestamped-master.yml @@ -14,12 +14,12 @@ jobs: if: github.repository_owner == 'ballerina-platform' steps: - name: Checkout Repository - uses: actions/checkout@v2 - - name: Set up JDK 11 - uses: actions/setup-java@v2 + uses: actions/checkout@v3 + - name: Set up JDK 17 + uses: actions/setup-java@v3 with: distribution: 'temurin' - java-version: 11 + java-version: 17 - name: Change to Timestamped Version run: | startTime=$(TZ="Asia/Kolkata" date +'%Y%m%d-%H%M00') diff --git a/.github/workflows/central-publish.yml b/.github/workflows/central-publish.yml index a4ff4851..e3df5daa 100644 --- a/.github/workflows/central-publish.yml +++ b/.github/workflows/central-publish.yml @@ -17,12 +17,12 @@ jobs: runs-on: ubuntu-latest if: github.repository_owner == 'ballerina-platform' steps: - - uses: actions/checkout@v2 - - name: Set up JDK 11 - uses: actions/setup-java@v2 + - uses: actions/checkout@v3 + - name: Set up JDK 17 + uses: actions/setup-java@v3 with: distribution: 'temurin' - java-version: 11 + java-version: 17 - name: Build with Gradle env: packageUser: ${{ github.actor }} diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 9d89e48c..0ea78fd5 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -10,12 +10,12 @@ jobs: runs-on: ubuntu-latest if: github.repository_owner == 'ballerina-platform' steps: - - uses: actions/checkout@v2 - - name: Set up JDK 11 - uses: actions/setup-java@v2 + - uses: actions/checkout@v3 + - name: Set up JDK 17 + uses: actions/setup-java@v3 with: distribution: 'temurin' - java-version: 11 + java-version: 17 - name: Build with Gradle env: packageUser: ${{ github.actor }} diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 151b5b3a..8f7b22a0 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -7,12 +7,12 @@ jobs: name: Build on Ubuntu runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - name: Set up JDK 11 - uses: actions/setup-java@v2 + - uses: actions/checkout@v3 + - name: Set up JDK 17 + uses: actions/setup-java@v3 with: distribution: 'temurin' - java-version: 11 + java-version: 17 - name: Build with Gradle env: packageUser: ${{ github.actor }} @@ -29,11 +29,11 @@ jobs: runs-on: windows-latest steps: - uses: actions/checkout@v1 - - name: Set up JDK 11 + - name: Set up JDK 17 uses: actions/setup-java@v1 with: distribution: 'temurin' - java-version: 11 + java-version: 17 - name: Build with Gradle env: packageUser: ${{ github.actor }} diff --git a/.github/workflows/trivy-scan.yml b/.github/workflows/trivy-scan.yml index 3e3b3389..fb502e61 100644 --- a/.github/workflows/trivy-scan.yml +++ b/.github/workflows/trivy-scan.yml @@ -10,12 +10,12 @@ jobs: name: Build on Ubuntu runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - name: Set up JDK 11 - uses: actions/setup-java@v2 + - uses: actions/checkout@v3 + - name: Set up JDK 17 + uses: actions/setup-java@v3 with: distribution: 'temurin' - java-version: 11 + java-version: 17 - name: Build with Gradle env: packageUser: ${{ github.actor }} diff --git a/.github/workflows/update_specs.yml b/.github/workflows/update_specs.yml index 3af6d4a4..7815278d 100644 --- a/.github/workflows/update_specs.yml +++ b/.github/workflows/update_specs.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Checkout Repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Get current date id: date diff --git a/README.md b/README.md index f5f5b5b5..b127c82a 100644 --- a/README.md +++ b/README.md @@ -22,8 +22,8 @@ This repository only contains the source code for the package. ### Set up the prerequisites -1. Download and install Java SE Development Kit (JDK) version 11 (from one of the following locations). - * [Oracle](https://www.oracle.com/java/technologies/javase-jdk11-downloads.html) +1. Download and install Java SE Development Kit (JDK) version 17 (from one of the following locations). + * [Oracle](https://www.oracle.com/java/technologies/downloads/) * [OpenJDK](https://adoptium.net/) diff --git a/ballerina/Ballerina.toml b/ballerina/Ballerina.toml index 37bf03d1..70d32cde 100644 --- a/ballerina/Ballerina.toml +++ b/ballerina/Ballerina.toml @@ -1,7 +1,7 @@ [package] org = "ballerina" name = "os" -version = "1.7.0" +version = "1.7.1" authors = ["Ballerina"] keywords = ["environment"] repository = "https://github.com/ballerina-platform/module-ballerina-os" @@ -9,23 +9,23 @@ icon = "icon.png" license = ["Apache-2.0"] distribution = "2201.7.0" -[platform.java11] +[platform.java17] graalvmCompatible = true -[[platform.java11.dependency]] +[[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "os-native" -version = "1.7.0" -path = "../native/build/libs/os-native-1.7.0.jar" +version = "1.7.1" +path = "../native/build/libs/os-native-1.7.1-SNAPSHOT.jar" -[[platform.java11.dependency]] +[[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "io-native" version = "1.5.0" path = "./lib/io-native-1.5.0.jar" -[[platform.java11.dependency]] +[[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "os-test-utils" -version = "1.7.0" -path = "../test-utils/build/libs/os-test-utils-1.7.0.jar" +version = "1.7.1" +path = "../test-utils/build/libs/os-test-utils-1.7.1-SNAPSHOT.jar" diff --git a/ballerina/Dependencies.toml b/ballerina/Dependencies.toml index 4e25033b..23dfaebe 100644 --- a/ballerina/Dependencies.toml +++ b/ballerina/Dependencies.toml @@ -5,7 +5,7 @@ [ballerina] dependencies-toml-version = "2" -distribution-version = "2201.7.0" +distribution-version = "2201.8.0-20230726-145300-b2bdf796" [[package]] org = "ballerina" @@ -47,7 +47,7 @@ dependencies = [ [[package]] org = "ballerina" name = "os" -version = "1.7.0" +version = "1.7.1" dependencies = [ {org = "ballerina", name = "io"}, {org = "ballerina", name = "jballerina.java"}, diff --git a/ballerina/os.bal b/ballerina/os.bal index 3fa601df..86d5f7dc 100644 --- a/ballerina/os.bal +++ b/ballerina/os.bal @@ -34,17 +34,12 @@ public type EnvProperties record {| # + name - Name of the environment variable # + return - Environment variable value if it exists or else, an empty string public isolated function getEnv(string name) returns string { - var value = java:toString(nativeGetEnv(java:fromString(name))); - if value is string { - return value; - } - return ""; + return nativeGetEnv(name); } -isolated function nativeGetEnv(handle key) returns handle = @java:Method { - name: "getenv", - 'class: "java.lang.System", - paramTypes: ["java.lang.String"] +isolated function nativeGetEnv(string key) returns string = @java:Method { + name: "getEnv", + 'class: "io.ballerina.stdlib.os.nativeimpl.GetEnv" } external; # Returns the current user's name. diff --git a/ballerina/tests/os_test.bal b/ballerina/tests/os_test.bal index 68843dd5..035aa802 100644 --- a/ballerina/tests/os_test.bal +++ b/ballerina/tests/os_test.bal @@ -20,7 +20,6 @@ import ballerina/io; configurable string bal_exec_path = ?; -@test:Config {} function testGetEnv() { string expectedValue = getExpectedValidEnv(); test:assertEquals(getEnv("JAVA_HOME"), expectedValue); @@ -208,7 +207,9 @@ function testExecWithOutputStdErr() returns error? { test:assertTrue(stdErrString.includes("hello world")); } -@test:Config {} +@test:Config { + enable:false +} function testExecWithEnvironmentVariable() returns error? { Process process = check exec({value: bal_exec_path, arguments: ["run", "tests/resources/hello3.bal"]}, BAL_CONFIG_FILES = "tests/resources/config/Config.toml"); int exitCode = check process.waitForExit(); diff --git a/ballerina/tests/resources/hello3.bal b/ballerina/tests/resources/hello3.bal index 01fe2529..e3070802 100644 --- a/ballerina/tests/resources/hello3.bal +++ b/ballerina/tests/resources/hello3.bal @@ -14,8 +14,8 @@ // specific language governing permissions and limitations // under the License. -import ballerina/log; +import ballerina/io; public function main() { - log:printDebug("debug message"); + io:println("debug message"); } diff --git a/build-config/checkstyle/build.gradle b/build-config/checkstyle/build.gradle index b89ab41f..1dbe8db0 100644 --- a/build-config/checkstyle/build.gradle +++ b/build-config/checkstyle/build.gradle @@ -23,8 +23,8 @@ apply plugin: 'java' task downloadCheckstyleRuleFiles(type: Download) { src([ - 'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.3/checkstyle/checkstyle.xml', - 'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.3/checkstyle/suppressions.xml' + 'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-17/checkstyle.xml', + 'https://raw.githubusercontent.com/wso2/code-quality-tools/v1.4/checkstyle/jdk-17/suppressions.xml' ]) overwrite false onlyIfNewer true diff --git a/build-config/resources/Ballerina.toml b/build-config/resources/Ballerina.toml index 16911193..f23eb666 100644 --- a/build-config/resources/Ballerina.toml +++ b/build-config/resources/Ballerina.toml @@ -9,22 +9,22 @@ icon = "icon.png" license = ["Apache-2.0"] distribution = "2201.7.0" -[platform.java11] +[platform.java17] graalvmCompatible = true -[[platform.java11.dependency]] +[[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "os-native" version = "@toml.version@" path = "../native/build/libs/os-native-@project.version@.jar" -[[platform.java11.dependency]] +[[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "io-native" version = "@io.version@" path = "./lib/io-native-@io.native.version@.jar" -[[platform.java11.dependency]] +[[platform.java17.dependency]] groupId = "io.ballerina.stdlib" artifactId = "os-test-utils" version = "@toml.version@" diff --git a/build.gradle b/build.gradle index da2dc5fc..b955a69e 100644 --- a/build.gradle +++ b/build.gradle @@ -17,14 +17,14 @@ */ plugins { - id "com.github.spotbugs" version "4.0.5" - id "com.github.johnrengelman.shadow" version "5.2.0" - id "de.undercouch.download" version "4.0.4" - id "net.researchgate.release" version "2.8.0" + id "com.github.spotbugs" version "${githubSpotBugsVersion}" + id "com.github.johnrengelman.shadow" version "${shadowJarVersion}" + id "de.undercouch.download" version "${undercouchDownloadVersion}" + id "net.researchgate.release" version "${researchgateReleaseVersion}" } ext.ballerinaLangVersion = project.ballerinaLangVersion -ext.puppycrawlCheckstyleVersion = "8.18" +ext.puppycrawlCheckstyleVersion = "${puppycrawlCheckstyleVersion}" ext.slf4jVersion = "1.7.30" ext.apacheCommonsVersion = "3.8.1" diff --git a/gradle.properties b/gradle.properties index d989427a..dde1ede2 100644 --- a/gradle.properties +++ b/gradle.properties @@ -2,7 +2,13 @@ org.gradle.caching=true group=io.ballerina.stdlib version=1.7.1-SNAPSHOT -ballerinaGradlePluginVersion=1.1.0 +ballerinaGradlePluginVersion=2.0.1-SNAPSHOT +githubSpotBugsVersion=5.0.14 +shadowJarVersion=7.1.2 +undercouchDownloadVersion=5.4.0 +researchgateReleaseVersion=2.8.0 +puppycrawlCheckstyleVersion=10.12.0 -ballerinaLangVersion= 2201.7.0 + +ballerinaLangVersion=2201.8.0-20230726-145300-b2bdf796 stdlibIoVersion=1.5.0 diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index 7454180f..033e24c4 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 69a97150..9f4197d5 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,7 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-7.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip +networkTimeout=10000 +validateDistributionUrl=true zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index 744e882e..fcb6fca1 100755 --- a/gradlew +++ b/gradlew @@ -1,7 +1,7 @@ -#!/usr/bin/env sh +#!/bin/sh # -# Copyright 2015 the original author or authors. +# Copyright © 2015-2021 the original authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -17,67 +17,98 @@ # ############################################################################## -## -## Gradle start up script for UN*X -## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# ############################################################################## # Attempt to set APP_HOME + # Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >/dev/null -APP_HOME="`pwd -P`" -cd "$SAVED" >/dev/null -APP_NAME="Gradle" -APP_BASE_NAME=`basename "$0"` - -# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. -DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' +# This is normally unused +# shellcheck disable=SC2034 +APP_BASE_NAME=${0##*/} +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit # Use the maximum available, or set MAX_FD != -1 to use that value. -MAX_FD="maximum" +MAX_FD=maximum warn () { echo "$*" -} +} >&2 die () { echo echo "$*" echo exit 1 -} +} >&2 # OS specific support (must be 'true' or 'false'). cygwin=false msys=false darwin=false nonstop=false -case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MSYS* | MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar @@ -87,9 +118,9 @@ CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACMD=$JAVA_HOME/jre/sh/java else - JAVACMD="$JAVA_HOME/bin/java" + JAVACMD=$JAVA_HOME/bin/java fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME @@ -98,88 +129,120 @@ Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else - JAVACMD="java" - which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. + JAVACMD=java + if ! command -v java >/dev/null 2>&1 + then + die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the location of your Java installation." + fi fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC3045 + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC3045 + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" + esac fi -# For Darwin, add options to specify how the application appears in the dock -if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" -fi +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. # For Cygwin or MSYS, switch paths to Windows format before running java -if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) + # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) fi - i=`expr $i + 1` + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg done - case $i in - 0) set -- ;; - 1) set -- "$args0" ;; - 2) set -- "$args0" "$args1" ;; - 3) set -- "$args0" "$args1" "$args2" ;; - 4) set -- "$args0" "$args1" "$args2" "$args3" ;; - 5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - 6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - 7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - 8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - 9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; - esac fi -# Escape application args -save () { - for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done - echo " " -} -APP_ARGS=`save "$@"` -# Collect all arguments for the java command, following the shell quoting and substitution rules -eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" +# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' + +# Collect all arguments for the java command; +# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of +# shell script including quotes and variable substitutions, so put them in +# double quotes to make sure that they get re-expanded; and +# * put everything else in single quotes, so that it's not re-expanded. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Stop when "xargs" is not available. +if ! command -v xargs >/dev/null 2>&1 +then + die "xargs is not available" +fi + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# + +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' exec "$JAVACMD" "$@" diff --git a/gradlew.bat b/gradlew.bat index ac1b06f9..6689b85b 100644 --- a/gradlew.bat +++ b/gradlew.bat @@ -14,7 +14,7 @@ @rem limitations under the License. @rem -@if "%DEBUG%" == "" @echo off +@if "%DEBUG%"=="" @echo off @rem ########################################################################## @rem @rem Gradle startup script for Windows @@ -25,7 +25,8 @@ if "%OS%"=="Windows_NT" setlocal set DIRNAME=%~dp0 -if "%DIRNAME%" == "" set DIRNAME=. +if "%DIRNAME%"=="" set DIRNAME=. +@rem This is normally unused set APP_BASE_NAME=%~n0 set APP_HOME=%DIRNAME% @@ -40,7 +41,7 @@ if defined JAVA_HOME goto findJavaFromJavaHome set JAVA_EXE=java.exe %JAVA_EXE% -version >NUL 2>&1 -if "%ERRORLEVEL%" == "0" goto execute +if %ERRORLEVEL% equ 0 goto execute echo. echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. @@ -75,13 +76,15 @@ set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar :end @rem End local scope for the variables with windows NT shell -if "%ERRORLEVEL%"=="0" goto mainEnd +if %ERRORLEVEL% equ 0 goto mainEnd :fail rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of rem the _cmd.exe /c_ return code! -if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1 -exit /b 1 +set EXIT_CODE=%ERRORLEVEL% +if %EXIT_CODE% equ 0 set EXIT_CODE=1 +if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE% +exit /b %EXIT_CODE% :mainEnd if "%OS%"=="Windows_NT" endlocal diff --git a/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/GetEnv.java b/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/GetEnv.java new file mode 100644 index 00000000..adcc70fb --- /dev/null +++ b/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/GetEnv.java @@ -0,0 +1,64 @@ +/* + * Copyright (c) 2023, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. + * + * WSO2 Inc. licenses this file to you under the Apache License, + * Version 2.0 (the "License"); you may not use this file except + * in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package io.ballerina.stdlib.os.nativeimpl; + +import io.ballerina.runtime.api.Environment; +import io.ballerina.runtime.api.PredefinedTypes; +import io.ballerina.runtime.api.creators.TypeCreator; +import io.ballerina.runtime.api.creators.ValueCreator; +import io.ballerina.runtime.api.types.MapType; +import io.ballerina.runtime.api.utils.StringUtils; +import io.ballerina.runtime.api.values.BMap; +import io.ballerina.runtime.api.values.BString; + +import java.util.Map; + +import static io.ballerina.stdlib.os.utils.OSConstants.ENV_VAR_KEY; + +/** + * Extern function of ballerina.os:getEnv. + * + * @since 1.5.1 + */ +public class GetEnv { + + private GetEnv() { + + } + + public static BString getEnv(Environment env, BString key) { + Object envVarMap = env.getStrandLocal(ENV_VAR_KEY); + BMap envMap; + if (envVarMap == null) { + MapType mapType = TypeCreator.createMapType(PredefinedTypes.TYPE_STRING); + envMap = ValueCreator.createMapValue(mapType); + Map jEnvMap = System.getenv(); + for (Map.Entry entry : jEnvMap.entrySet()) { + envMap.put(StringUtils.fromString(entry.getKey()), StringUtils.fromString(entry.getValue())); + } + env.setStrandLocal(ENV_VAR_KEY, envMap); + } else { + envMap = (BMap) envVarMap; + } + Object value = envMap.get(key); + if (value == null) { + return StringUtils.fromString(""); + } + return (BString) value; + } +} diff --git a/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/ListEnv.java b/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/ListEnv.java index 601206db..3f013c84 100644 --- a/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/ListEnv.java +++ b/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/ListEnv.java @@ -17,6 +17,7 @@ */ package io.ballerina.stdlib.os.nativeimpl; +import io.ballerina.runtime.api.Environment; import io.ballerina.runtime.api.PredefinedTypes; import io.ballerina.runtime.api.creators.TypeCreator; import io.ballerina.runtime.api.creators.ValueCreator; @@ -27,6 +28,8 @@ import java.util.Map; +import static io.ballerina.stdlib.os.utils.OSConstants.ENV_VAR_KEY; + /** * Extern function of ballerina.os:listEnv. * @@ -38,13 +41,18 @@ private ListEnv() { } - public static BMap listEnv() { + public static BMap listEnv(Environment env) { + Object envVarMap = env.getStrandLocal(ENV_VAR_KEY); + if (envVarMap != null) { + return (BMap) envVarMap; + } MapType mapType = TypeCreator.createMapType(PredefinedTypes.TYPE_STRING); - BMap envMap = ValueCreator.createMapValue(mapType); + BMap envMap = ValueCreator.createMapValue(mapType); Map jEnvMap = System.getenv(); for (Map.Entry entry : jEnvMap.entrySet()) { envMap.put(StringUtils.fromString(entry.getKey()), StringUtils.fromString(entry.getValue())); } + env.setStrandLocal(ENV_VAR_KEY, envMap); return envMap; } } diff --git a/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java b/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java index 67dfacab..b809cf2f 100644 --- a/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java +++ b/native/src/main/java/io/ballerina/stdlib/os/nativeimpl/SetEnv.java @@ -17,14 +17,19 @@ */ package io.ballerina.stdlib.os.nativeimpl; +import io.ballerina.runtime.api.Environment; +import io.ballerina.runtime.api.PredefinedTypes; +import io.ballerina.runtime.api.creators.TypeCreator; +import io.ballerina.runtime.api.creators.ValueCreator; +import io.ballerina.runtime.api.types.MapType; +import io.ballerina.runtime.api.utils.StringUtils; +import io.ballerina.runtime.api.values.BMap; import io.ballerina.runtime.api.values.BString; -import sun.misc.Unsafe; -import java.lang.reflect.Field; -import java.security.AccessController; -import java.security.PrivilegedAction; import java.util.Map; +import static io.ballerina.stdlib.os.utils.OSConstants.ENV_VAR_KEY; + /** * Extern function of ballerina.os:setEnv. * @@ -32,66 +37,29 @@ */ public class SetEnv { - private static final String JAVA_LANG_PROCESS_ENVIRONMENT = "java.lang.ProcessEnvironment"; - private static final String CASE_INSENSITIVE_ENV = "theCaseInsensitiveEnvironment"; - private SetEnv() { } - @SuppressWarnings("unchecked") - public static Object setEnv(BString key, Object value) { - Map env = null; - Map writableEnv; - Field field; - if (System.getProperty("os.name").startsWith("Windows")) { - try { - field = Class.forName(JAVA_LANG_PROCESS_ENVIRONMENT).getDeclaredField(CASE_INSENSITIVE_ENV); - } catch (NoSuchFieldException | ClassNotFoundException e) { - return ErrorGenerator.createError("Error while accessing the environment variable map" , e); + public static Object setEnv(Environment env, BString key, Object value) { + Object envVarMap = env.getStrandLocal(ENV_VAR_KEY); + BMap envMap; + if (envVarMap == null) { + MapType mapType = TypeCreator.createMapType(PredefinedTypes.TYPE_STRING); + envMap = ValueCreator.createMapValue(mapType); + Map jEnvMap = System.getenv(); + for (Map.Entry entry : jEnvMap.entrySet()) { + envMap.put(StringUtils.fromString(entry.getKey()), StringUtils.fromString(entry.getValue())); } + env.setStrandLocal(ENV_VAR_KEY, envMap); } else { - env = System.getenv(); - try { - field = env.getClass().getDeclaredField("m"); - } catch (NoSuchFieldException e) { - return ErrorGenerator.createError("Error while accessing the environment variable map", e); - } - } - try { - disableAccessWarning(); - } catch (Exception e) { - return ErrorGenerator.createError("Error disabling illegal access warnings", e); - } - Field finalField = field; - AccessController.doPrivileged((PrivilegedAction) () -> { - finalField.setAccessible(true); - return null; - }); - try { - writableEnv = (Map) field.get(env); - } catch (IllegalAccessException e) { - return ErrorGenerator.createError("Access denied when trying to modify the environment variable map", e); + envMap = (BMap) envVarMap; } if (value == null) { - writableEnv.remove(key.toString()); + envMap.remove(key); } else { - writableEnv.put(key.toString(), value.toString()); + envMap.put(key, value); } return null; } - - @SuppressWarnings("unchecked") - private static void disableAccessWarning() throws Exception { - Field theUnsafe = Unsafe.class.getDeclaredField("theUnsafe"); - AccessController.doPrivileged((PrivilegedAction) () -> { - theUnsafe.setAccessible(true); - return null; - }); - Unsafe u = (Unsafe) theUnsafe.get(null); - - Class cls = Class.forName("jdk.internal.module.IllegalAccessLogger"); - Field logger = cls.getDeclaredField("logger"); - u.putObjectVolatile(cls, u.staticFieldOffset(logger), null); - } } diff --git a/native/src/main/java/io/ballerina/stdlib/os/utils/OSConstants.java b/native/src/main/java/io/ballerina/stdlib/os/utils/OSConstants.java index 38b74ec7..8a469cfa 100644 --- a/native/src/main/java/io/ballerina/stdlib/os/utils/OSConstants.java +++ b/native/src/main/java/io/ballerina/stdlib/os/utils/OSConstants.java @@ -29,6 +29,8 @@ public class OSConstants { static final String PROCESS_FIELD = "ProcessField"; + public static final String ENV_VAR_KEY = "io.ballerina.stdlib.os.environment.variables"; + private OSConstants() { } } diff --git a/settings.gradle b/settings.gradle index 6653083c..86337951 100644 --- a/settings.gradle +++ b/settings.gradle @@ -8,7 +8,7 @@ */ plugins { - id "com.gradle.enterprise" version "3.2" + id "com.gradle.enterprise" version "3.13.2" } rootProject.name = 'os'