Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup page leftovers #2849

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Signup page leftovers #2849

merged 9 commits into from
Nov 27, 2024

Commits on Nov 18, 2024

  1. refactor(workflow): remove createCollectionFlowToken references

    - Clean up the workflow configuration schema by removing the createCollectionFlowToken option
    - Update various workflow definition files to eliminate obsolete token settings
    
    (your code was so cluttered, it looked like a toddler's art project on a bad day)
    tomer-shvadron committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    60e8f29 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    2e96012 View commit details
    Browse the repository at this point in the history
  2. refactor(workflow): streamline collection flow state creation

    - Remove unnecessary intermediate variable in buildCollectionFlowState
    - Reorganize import statements for better readability
    - Add a count method in WorkflowTokenService for token existence checks
    
    (Your code is so bloated, it could use a good diet and some introspection)
    tomer-shvadron committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4d7664c View commit details
    Browse the repository at this point in the history
  3. refactor(auth): update module imports for improved path clarity

    - Replace relative imports with absolute paths for better readability
    - Add additional providers to the TokenAuthModule for expanded functionality
    
    (You’re like a pathing guide in a maze – leading the way, but it’s still a bit of a headache)
    tomer-shvadron committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9bfca66 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9426d95 View commit details
    Browse the repository at this point in the history
  5. refactor(workflow): rename service variable for clarity

    - Replace ambiguous service variable with workflowService
    - Update all references to maintain consistency
    - Enhance code readability and prevent confusion
    
    (Your variable names are like trying to find a needle in a haystack without the hay)
    tomer-shvadron committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    01de2c2 View commit details
    Browse the repository at this point in the history
  6. test(collection-flow): enhance integration tests for CollectionFlowNo…

    …UserController
    
    - Add imports for UiDefinitionRepository and ApiKey services
    - Include new dependencies in module testing setup
    - Create a new UI definition instance as part of the test setup
    
    (your tests are more complex than explaining the plot of Inception)
    tomer-shvadron committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    0982228 View commit details
    Browse the repository at this point in the history
  7. test(collection-flow): enhance integration tests for collection flow …

    …service
    
    - Add integration test for UI definition repository
    - Update results validation with environment variables
    
    (These tests are so robust, they can survive a zombie apocalypse… but maybe not a spelling mistake)
    tomer-shvadron committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    dd2f683 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    00d6b02 View commit details
    Browse the repository at this point in the history