Use device name instead of "product" in unreachable server error message (HifiberryOS)

[Bertware]

When the server cannot be reached, a very generic error message is shown. I suggest changing this error message to take the user-configured device name into account here. The user configured device name is already used in, among others, the window title, so this would make it more consistent and polished.

Current behaviour:
When restarting the hardware, the web page shows "product is unreachable".

Expected behaviour:
When restarting the hardware, the web page shows "<your_device_name> is unreachable".

Hardware:
Raspberry Pi 3 with Hifiberry DAC+ADC pro, HifiberryOS 20200908

The code for this error message is located at

create/Beocreate2/beo-system/common/scripts/beo-comms.js

Line 120 in 9cbc466

if (maxConnectionAttempts > 0 && !noConnectionNotifications && beo.notify) beo.notify({title: "Product is unreachable", message: "Make sure the product is on and that the product and your "+os[1]+" are connected to the same network.", buttonAction: "beoCom.connectToCurrentProduct();", buttonTitle: "Try Again", id: "connection", timeout: false});

[tuomashamalainen]

Thanks for your suggestion, it's a good one and I'll put it on the to-do list.

Here are the ways to restart the product:

• unplug and reconnect power (not recommended at this time)
• issue the reboot command via SSH/command line
• in the UI, General -> Power -> Restart

Using the last method should result in a nicer restart experience: the UI will show that the product is restarting and will keep searching for it for a much longer time, so that it will auto-connect once the restart finishes. Currently it's not possible for the product to communicate a restart to the UI in the first two scenarios, so you'll get the standard "dumb" connecting/disconnected flow instead.

Best,
Tuomas from Bang & Olufsen