Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests - code improvements #55

Open
1 of 3 tasks
lpuskas opened this issue Jun 6, 2018 · 1 comment
Open
1 of 3 tasks

Add more tests - code improvements #55

lpuskas opened this issue Jun 6, 2018 · 1 comment
Assignees
@lpuskas @prekoa
Labels
enhancement

Comments

@lpuskas
Copy link
Member

lpuskas commented Jun 6, 2018 •
edited
Loading

  • unit test uncovered generic code
  • unit tests for the gke recommendation code
  • unit tests for aks recomendation code
@lpuskas lpuskas changed the title Add more tests coverage Add more tests - code improvements Jun 7, 2018
@lpuskas lpuskas mentioned this issue Jun 14, 2018
Merged
@sancyx
Copy link
Member

sancyx commented Jan 30, 2019

Would be useful to add some test scenarios for scaleOut with a) the clusterLayout returned by recommendation call, b) the clusterLayout returned by recommendation call with decreased node counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpuskas lpuskas

@prekoa prekoa

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lpuskas @sancyx @prekoa