Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation for shared secrets with destinations #124

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

AlexB52
Copy link
Contributor

@AlexB52 AlexB52 commented Oct 6, 2024

On this documentation page, the documentation references .kamal/secrets as the common shared secret file but .kamal/secrets-common is the shared file instead.

I assumed .kamal/secrets-common is the correct behaviour from this pull request: basecamp/kamal#933

BEFORE

CleanShot 2024-10-06 at 16 18 16@2x

AFTER

CleanShot 2024-10-06 at 16 25 13@2x

	When using multiple deployment destinations, the fallback file for shared
	secrets isn't .kamal/secrets but .kamal/secrets-common.
@dhh dhh merged commit 87ba209 into basecamp:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants