Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #438 observation #448

Closed
acidtib opened this issue Sep 7, 2023 · 4 comments
Closed

PR #438 observation #448

acidtib opened this issue Sep 7, 2023 · 4 comments

Comments

@acidtib
Copy link
Contributor

acidtib commented Sep 7, 2023

hey @djmb great work on the new features, I have a small request Could we have a version bump when big changes like #438 are introduced? this PR just broke so many deployments.

Releasing the deploy lock...
  Finished all in 39.4 seconds
  ERROR (SSHKit::Command::Failed): Exception while executing on host xx.xx.xx.xx: docker exit status: 125
docker stdout: Nothing written
docker stderr: docker: open .kamal/env/roles/service_name-web.env: no such file or directory.
See 'docker run --help'.
@djmb
Copy link
Collaborator

djmb commented Sep 8, 2023

Hi and thanks @acidtib!

If you point to the released versions from RubyGems this shouldn't be an issue I think. Are you pulling Kamal directly from the main branch?

@delivey
Copy link

delivey commented Sep 11, 2023

Same issue happening for me. Have you found a fix?

@djmb
Copy link
Collaborator

djmb commented Sep 12, 2023

@delivey, how do you install Kamal? If you use gem install kamal it should only pull released versions from Rubygems.

@dhh
Copy link
Member

dhh commented Sep 16, 2023

The new features, with breakage, will be released as part of v1.0. But yeah, if you run off main, you have to expect that things might break!

@dhh dhh closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants