Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow false env var value #1045

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

junket
Copy link
Contributor

@junket junket commented Oct 3, 2024

I am booting an accessory that needs a clear env var value like ENABLE_AUTO_LOGIN=false so my config is just:

env:
  clear:
    ENABLE_AUTO_LOGIN: false

When Kamal passes such env vars to docker run it drops the false value since the argumentize utility checks that the value is present? and false values evaluate to false, leading to docker run --env ENABLE_AUTO_LOGIN

This PR updates argumentize to preserve false values, leading to docker run --env ENABLE_AUTO_LOGIN=false

@djmb djmb merged commit 66f6e8b into basecamp:main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants