SSH proxy: allow using a bare hostname without root@ #1048
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
force-pushed
the
proxy-with-bare-hostname
branch
2 times, most recently
from
4373d9d to
0e4f175
Compare
Otherwise we can't connect to the proxy as the local user and we can't use ~/.ssh/config to set User directives. Defaulting to root@ is hard to deprecate without introducing new config. A clean break is probably clearest.
jeremy
force-pushed
the
proxy-with-bare-hostname
branch
from
0e4f175 to
46e3085
Compare
|
@jeremy - I'll get the pending changes in master out in an release, and then release this on its own so the behaviour change isn't lost in a sea of release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we can't connect to the proxy as the local user and we can't use ~/.ssh/config to set
Userdirectives.Defaulting to
root@is hard to deprecate without introducing new config. A clean break is probably clearest.