[FIX] - Make kamal use ssh keys from config when performing commands #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we are getting some test failures in Ruby 3.4 I think because of the string mutation. |
For Ruby 3.4
|
Oh sorry, I didn't know about that, not sure if the fix is the idiomatic way, let me know if there's a better approach :) |
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I've taken this PR: #959 that worked fine and fixed the conflicts trying to maintain the approach of the previous code change for
ssh_proxy_args.I guess this PR should also fix #1053 and so we should probably be able to close this too: #1087