-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCP Secret Manager adapter #1236
base: main
Are you sure you want to change the base?
Add GCP Secret Manager adapter #1236
Conversation
@djmb I noticed you wrote the other adapters. Do you think this PR would be of use to the project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @andrelaszlo!
GCP Secret Manager is definitely something we'd want to support, so would be happy to get this added.
I've made some suggestions for changes to the PR to get it ready to merge.
Thank you for your thoughtful review @djmb. I've made all the changes you requested, synced with main, and made sure to run the full test suite as well ✔️ |
GCP Secret Manager adapter
This PR adds the
gcp_secret_manager
adapter (aliased togcp
andsecret_manager
). It uses thegcloud
CLI to fetch secrets from Google Cloud Platform's Secret Manager.The motivation to add this comes from my experience deploying apps to GCP using Kamal. Suggestions are welcome.
Some features like secret versioning, service account impersonation, and delegation chains are specific to GCP so I spent some time experimenting with various ways to specify these things without changing the
kamal secrets fetch
interface. An alternative route might be to add a way to pass options other than--account
to the adapter.In addition to the unit tests I've also tested this a bit with my personal GCP projects, but it hasn't been used in production.
Features:
gcloud
credentials and projectlatest
by defaultUsage: