Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump proxy minimum version to 0.8.3 #1253

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

AxelTheGerman
Copy link
Contributor

https://github.com/basecamp/kamal-proxy/releases/tag/v0.8.3

  • Populate X-Request-Start header
  • Log client disconnections with status 499
  • Use an identifiable User-Agent header on healthcheck requests
  • When target fails to become healthy, mention timeout in error message

Note: I'm also happy to implement a mechanism that doesn't require bumping the minimum version for every patch release. See #1252

@AxelTheGerman
Copy link
Contributor Author

@djmb do you think this could get merged or would you prefer having a solution that does not require bumping this version constantly and saving folks who don't care about it a proxy reboot?

@djmb djmb merged commit 084d1d4 into basecamp:main Dec 2, 2024
8 checks passed
@djmb
Copy link
Collaborator

djmb commented Dec 2, 2024

I've merged that, but looks like we need to bump it again for 0.8.4 😅

Regarding allowing users to choose the version, we should certainly allow patch version updates.

Kamal proxy hasn't reached 1.0 yet so we may want to make some breaking changes before then. But we don't have a backward or forward compatibility policy yet so it is safest to force the versions to be in sync right now.

@AxelTheGerman
Copy link
Contributor Author

Kamal proxy hasn't reached 1.0 yet so we may want to make some breaking changes before then. But we don't have a backward or forward compatibility policy yet so it is safest to force the versions to be in sync right now.

I assume at that point it would make sense to have a ruby gem style syntax for the proxy, e.g. ~> 1.2 or '>= 2.2.1', '< 3.0'

@AxelTheGerman AxelTheGerman deleted the proxy-0.8.3 branch December 3, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants