Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ssh forwarding to docker #235

Closed
wants to merge 6 commits into from

Conversation

dilpreet92
Copy link
Contributor

  • this will enable clone private gem repositories or in general forwarding ssh connection to docker

@dhh
Copy link
Member

dhh commented May 2, 2023

What benefit do you see here over using BUNDLE_GITHUB__COM with a Docker secret, as described in the README? https://github.com/mrsked/mrsk/#using-build-secrets-for-new-images

@dilpreet92
Copy link
Contributor Author

What benefit do you see here over using BUNDLE_GITHUB__COM with a Docker secret, as described in the README? https://github.com/mrsked/mrsk/#using-build-secrets-for-new-images

there might be some cases where private gems are being accessed using ssh and not https:.
gem 'abc', git: 'git@github.com:dilpreet92/xxx.git'
In order for SSH to work with Bundler, the user executing bundle install needs to have an authorized private key for the Github repo, so a common pattern is to use a machine user on CI, that has read access to all the repos it needs access to.

@djmb
Copy link
Collaborator

djmb commented Mar 7, 2024

Support for this was added in #434

@djmb djmb closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants