Supports Passing SSH Agent Socket to Build Options #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rience
force-pushed
the
ssh-agent-support
branch
from
5780603 to
039a147
Compare
rience
force-pushed
the
ssh-agent-support
branch
2 times, most recently
from
05d94ef to
c686b66
Compare
rience
force-pushed
the
ssh-agent-support
branch
from
c686b66 to
1c2a458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing ssh agent socket as documented in here: https://docs.docker.com/engine/reference/commandline/buildx_build/#ssh
This allows accessing private repositories without passing GITHUB_TOKEN.
If that's accepted - I'll follow up with PR to Kamal site with documentation.
P.S. Only after I opened this one I noticed #235 doing similar thing. This one though does not pass any SSH arguments if not configured - so it doesn't affect default behaviour. I'm happy to contribute to the other one if said so to get this merged.