Copy env files to remote hosts #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting env variables in the docker arguments requires having them on the deploy host. Instead we'll add two new commands `kamal env push` and `kamal env delete` which will manage copying the environment as .env files to the remote host. Docker will pick up the file with `--env-file <path-to-file>`. Env files will be stored under `<kamal run directory>/env`. Running `kamal env push` will create env files for each role and accessory, and traefik if required. `kamal envify` has been updated to also push the env files. By avoiding using `kamal envify` and creating the local and remote secrets manually, you can now avoid accessing secrets needed for the docker runtime environment locally. You will still need build secrets. One thing to note - the Docker doesn't parse the environment variables in the env file, one result of this is that you can't specify multi-line values - see moby/moby#12997. We maybe need to look docker config or docker secrets longer term to get around this. Hattip to @kevinmcconnell - this was all his idea.
djmb
force-pushed
the
remote-env-file
branch
from
989d09e to
94bf090
Compare
Closed
|
FYI this broke our deploy since the env files didn't exist and aren't created by Edit: I see there are some upgrade instructions in the release notes: https://github.com/basecamp/kamal/releases/tag/v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting env variables in the docker arguments requires having them on the deploy host.
Instead we'll add two new commands
kamal env pushandkamal env deletewhich will manage copying the environment as .env files to the remote host.Docker will pick up the file with
--env-file <path-to-file>. Env files will be stored under<kamal run directory>/env.Running
kamal env pushwill create env files for each role and accessory, and traefik if required.kamal envifyhas been updated to also push the env files.By avoiding using
kamal envifyand creating the local and remote secrets manually, you can now avoid accessing secrets needed for the docker runtime environment locally. You will still need build secrets.One thing to note - the Docker doesn't parse the environment variables in the env file, one result of this is that you can't specify multi-line values - see moby/moby#12997.
We maybe need to look docker config or docker secrets longer term to get around this.
Hat-tip to @kevinmcconnell - this was his idea.
Docs PR: basecamp/kamal-site#22