Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Healthcheck Expose Port #443

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

rience
Copy link
Contributor

@rience rience commented Sep 5, 2023

Healthcheck port (exposed one) is hard coded to 3999. This is a problem when doing parallel deployments and might result in this error

ERROR (SSHKit::Command::Failed): Exception while executing on host plus-6fc20fca3f82fa64049fec08bac4b533.svc: docker exit status: 125
--
  | docker stdout: fec19f2cf5310d4900e21ed48681ce9e896901185f656cfd1797d109af9bf251
  | docker stderr: docker: Error response from daemon: driver failed programming external connectivity on endpoint healthcheck-xxx (92d063a6607cbf7525970c123a75598dcde5dae34862ad9e436c05e9bcb82406): Bind for 0.0.0.0:3999 failed: port is already allocated.

This PR adds an option to healthcheck configuration and allow to pass exposed_port via configuration. Default value stays the same and is still 3999.

@djmb djmb merged commit fd6bf53 into basecamp:main Sep 6, 2023
6 checks passed
@rience rience deleted the custom-healthcheck-port branch September 6, 2023 13:17
@brunoprietog
Copy link
Contributor

Can you document this in kamal-site? Otherwise I will try to do it when I have some time

@rience
Copy link
Contributor Author

rience commented Sep 6, 2023

PR created: basecamp/kamal-site#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants