Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Deploy Config with *.erb Extension if Exists #463

Closed
wants to merge 1 commit into from

Conversation

rience
Copy link
Contributor

@rience rience commented Sep 13, 2023

At the moment configuration is by default loaded from deploy.yml file. It's the evaluated using ERB. But that means that IDE won't pick up ERB dialect. It'd be great if you could create deploy.yml.erb file and do not have to pass path to this file using -c flag.

So this PR is adding two things

  1. If configuration file with "erb" extension exists - it'll be loaded instead
    • For example if deploy.yml.erb exists - it'll be loaded instead of deploy.yml
    • If custom config custom_deploy.yml.erb exists - it'll also be loaded instead of custom_deploy.yml (Note: this will also happens when you specify -c custom_deploy.yml)
  2. It's also changing one of fixtures from deploy.erb.yml to depoy.yml.erb since I think this should be default naming for template file (just like in Rails you have *.html.erb)

@rience
Copy link
Contributor Author

rience commented Sep 14, 2023

Closing this as #391 is I think better solution than this since it honours "destination" setting.

@rience rience closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant