Copy all files into asset volume #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding -T to the copy command ensures that the files are copied at the same level into the target directory whether it exists or not. That allows us to drop the `/*` which was not picking up hidden files. Fixes: #465
jeremy
reviewed
Sep 21, 2023
| @@ -234,6 +234,6 @@ def find_and_remove_older_siblings(path) | |||
| end | |||
|
|
|||
| def copy_contents(source, destination, continue_on_error: false) | |||
| [ :cp, "-rn", "#{source}/*", destination, *("|| true" if continue_on_error)] | |||
| [ :cp, "-rnT", "#{source}", destination, *("|| true" if continue_on_error)] | |||
There was a problem hiding this comment.
Looks like -T is GNU-only. Copying "#{source}/.", "#{destination}/." could be a workaround, avoiding the differing trailing-slash behavior in BSD vs GNU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding -T to the copy command ensures that the files are copied at the same level into the target directory whether it exists or not.
That allows us to drop the
/*which was not picking up hidden files.Fixes: #465