[WIP] Specify env file + envify on the config file #825
+25
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode is to force a environment there
fabiosammy
changed the title
fabiosammy
commented
May 30, 2024
Comment on lines
+175
to
+177
| elsif envify_from_config = KAMAL.config.raw_config["envify"] | ||
| env_template_path = ".env.#{envify_from_config}.erb" | ||
| env_path = ".env.#{envify_from_config}" |
There was a problem hiding this comment.
We can extract this to his own PR.
| delegate :argumentize, to: Kamal::Utils | ||
|
|
||
| def self.from_config(config:, secrets_file: nil) | ||
| secrets_keys = config.fetch("secret", []) | ||
| clear = config.fetch("clear", config.key?("secret") || config.key?("tags") ? {} : config) | ||
| env_key_config = config.class == Kamal::Configuration ? config.env : config.fetch("env", {}) |
There was a problem hiding this comment.
The "config" variable name is not too clear to what this represents. This is not "config", this is the "env" key from config with this values. Maybe we can also extract this to his own PR also?
Comment on lines
+31
to
+37
| # TODO: More than one @env_file | ||
| # TODO: Considerer a merge between env_file and env | ||
| if @env_file | ||
| Dotenv::Environment.new(@env_file) | ||
| else | ||
| secrets_keys.to_h { |key| [ key, ENV.fetch(key) ] } | ||
| end |
There was a problem hiding this comment.
This is the main goal. Not sure how we can tackle this.
The reason behind this is to push an env file with "gazillions" of environment variables that can be related to the application code or not.
Any thoughts @djmb ? (sorry to tag you, but I saw that you did the last merges around here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main goal is to upload a custom env, entirely to the app or accessory.
Some projects have the
.envcommitted inside of the git repository, and some of them have so much env that update his values, remove the keys or add new ones without changing the application code.Also I put the "for_node" and "custom_env" to debug and understand the gem.
Lack of tests.
This is more a PR to discuss an approach rather than something ready to merge.