[bitwarden] ability to fetch all fields from an item #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmb
reviewed
Sep 30, 2024
honzasterba
force-pushed
the
bw_fetch_all_fields
branch
2 times, most recently
from
81cea7b to
1d4a804
Compare
honzasterba
force-pushed
the
bw_fetch_all_fields
branch
from
1d4a804 to
e87349a
Compare
|
Please let me know if there is anything I can do to move this along, or if should just give up and close it. |
djmb
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Sorry for the delay, @honzasterba, I've been away.
I think the current approach looks good! Just one suggestion about how fetch_secrets_from_fields if called and I think we are good to go.
Sometimes a projects has a lot of secrets (more than 10). And its cumbersome to write $(kama secrets fetch ...) with a lot of field names. I want to be able to just fetch all the fields from a given item and then just use these with $(kamal extract NAME)
honzasterba
force-pushed
the
bw_fetch_all_fields
branch
from
e87349a to
7142534
Compare
djmb
approved these changes
Oct 23, 2024
|
Thank you! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a projects has a lot of secrets (more than 10). And its cumbersome to write $(kama secrets fetch ...) with a lot of field names.
I want to be able to just fetch all the fields from a given item and then just use these with $(kamal extract NAME)
The result is that you can: