Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_dump detaches current memory segment, creates new [JIRA: RIAK-2104] #168

Open
matthewvon opened this issue Aug 18, 2015 · 1 comment

Comments

@matthewvon
Copy link
Contributor

perf_dump is supposed to perform only read operations against the shared memory segment. However, it calls leveldb::Env::Default() which also accesses the shared memory segment and will resize it if necessary. This is bad behavior. Env object is only used for its NowTime(). Best bet is to likely copy that routine to perf_dump.cc, or create static equivalent that perf_dump can call (and is also called by env_posix's NowTime() routine).

@Basho-JIRA Basho-JIRA changed the title perf_dump detaches current memory segment, creates new perf_dump detaches current memory segment, creates new [JIRA: RIAK-2104] Aug 18, 2015
@matthewvon
Copy link
Contributor Author

mv-expiry branch adds leveldb::port::NowUint64() clock as alternative to Env::NowMicros(). perf_dump.cc updated to use new API in that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants