Normal battle doesn't load

[bates64]

No description provided.

[randomname42]

I'm surprised this hasn't been fixed after so long. Normal Battle still fails close to a year later (unmodified rom), with this message:

Error loading song
Failed to decode the BGM.
If this is an unmodified ROM, please report this as a bug.
Unexpected end-of-file

[bates64]

Hi @randomname42, I work on this project and many others in a completely voluntary capacity, so its expected that some things might go unfixed after indeterminate periods of time. I have other things to do.

Yes, that's the error.

The reason this occurs is, if I remember correctly, due to lack of support for BGM command 0xFF:

https://github.com/nanaian/mamar/blob/aba939ba2c9ed2481af56c9a16f4b0ae53ffcc11/pm64/src/bgm/cmd.rs#L589-L593

This is the same reason that Toad Town doesn't load, I think. Either way, support for it will fix problems somewhere.

The function that handles this has been decompiled, but its not documented or well-understood. If you or anyone else wants to perform the reverse-engineering work to figure out what the values are and how Mamar could interpret it correctly, be my guest.

[ethteck]

I'm surprised this hasn't been fixed after so long

@randomname42 why? And even if that is how you feel, why would you say that? What could you possibly hope to achieve other than trying to make someone feel bad for not meeting your expectations? And why would you try to make someone who is providing you a service for free feel bad? Needless to say, this isn't how you communicate to a maintainer of an open source project.

A person has no obligation to ever update or maintain a free thing made in their free time. If you somehow have expectations of a person to maintain their free product, you need to learn how to handle that on your own.

If your goal was merely to voice that this affects you and you'd like it prioritized, there are much nicer ways to do that. An example would be "I'm running into this in what I'm working on" or even to upvote the issue. There's so many other ways to do this that would be better than trying to shame a developer for not having fixed a bug.

[randomname42]

I honestly don't know what caused me to post something like that. Looking at it again I'm shocked I could post something like that and somehow be oblivious to what it would be like for the other person too. I'm going to have to think about this.

I'm sorry for any bad feelings it caused. In no way did you deserve that. There must be something going on with me that I need to figure out, and I'm sorry that came out here and affected you.

What I should have said is that I was confused that the issue is known for some time, but the program gives a message saying to create an issue about it, which left me genuinely perplexed. If there's a simple way to change the error to say that this is a known issue it would help someone who's new to Mamar to not get confused.

I don't know what to do now. Is it better edit my first message to get rid of the crappiness or to leave it?

[ethteck]

I was confused that the issue is known for some time, but the program gives a message saying to create an issue about it, which left me genuinely perplexed. If there's a simple way to change the error to say that this is a known issue it would help someone who's new to Mamar to not get confused.

That's a good suggestion imo!

It was cool of you to reflect on this, and I appreciate you hearing what I had to say. I had a feeling this didn't come from a nasty place or anything like that. I'll leave it to Alex to decide how he wants the message handled or whatever :)