Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid client-side file upload to bucket; use server-side #379

Open
j-mao opened this issue Jan 25, 2020 · 0 comments
Open

Avoid client-side file upload to bucket; use server-side #379

j-mao opened this issue Jan 25, 2020 · 0 comments
Labels
backend Related to competition website backend. critical frontend Related to the competition website.

Comments

@j-mao
Copy link
Member

j-mao commented Jan 25, 2020

File upload to bucket is used for processing submissions and resumes. Currently, in both cases the API returns a signed URL which the client can then use to upload the file directly to the bucket.

However if the client goes wrong (which internet browsers are wont to do), then the backend database records an upload, but the upload does not occur successfully. Specific causes may include the end-user refreshing the page before the upload completes, or unexpected errors during upload (e.g. CORS). This may be a cause of #194.

Using server-side file uploads will better ensure that anything recorded in the database actually exists. Additionally we can do the same thing to implement #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to competition website backend. critical frontend Related to the competition website.
Projects
None yet
Development

No branches or pull requests

1 participant