-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated mode breaks latest version of VS Code (on Fedora) #160
Comments
quick update: the latest version of vscode to actually work is vscode 1.81 |
@billbsu open vscode in a terminal and paste the logs here |
@billbsu, I was the main contributor for release 3.4.0. First let me thank you for reporting your issue. And please do post your logs so we can get to the bottom of it. But, the only thing that changed in 3.4.0 was to cache the nvidia pci bus id so that a transition from integrated directly to nvidia mode is now possible. Please see the Files changed tab of PR #155 . Note that #156 was probably included as well, but that PR had no code changes. I use VS Code 1.87.2 on Fedora 39 for all my dev as well. And it works fine on my ACER Nitro 5 with RTX 3050 Ti Mobile in integrated mode. I just now tested both with rpmfusion Nvidia drivers installed and without. Everything works fine for me in integrated mode. FYI, on the HD with the drivers installed, I ran dnf update and saw no kernel updates, but saw this come through: Please mention which deployment mechanism you use. I looked up your laptop and it looks like it has RTX 3060 Ti Mobile PC Mag Review. Your May I please ask you to also weigh in on #157 ? This uses a completely different approach for switching to integrated mode. It simply turns the power off to the nvidia gpu so it does not appear on the bus. It would be really good for us to hear if this solves your issue. Thanks again. |
Thank you for looking into it! lspci output: I installed vscode 1.87 according to MS instructions. Right now, I have 1.81 installed using rpm. I just tested it again. So vscode version 1.87.2 actually eventually does load after a few minutes, but after a while, it froze up and crashed. I'm sorry, I'm a bit inexperienced with these kinds of things, how do I dump the startup log files after running code? I will try the #157 fix in a bit. Thank you! |
@billbsu do you also experience this issue on other Electron apps or Chromium based browsers? |
I think discord is electron based and it works fine. And older versions of VS Code work fine. Chrome also launches fine but I don't use it so it may be bugged. Hope this helps! |
Can you check if there are logs on this path |
20240324T131631.zip Also, modinfo -F version nvidia shows my driver version. I don't think it did this before in integrated mode. Does that mean it's not working? |
I can't find anything relevant in the logs aside from this entry
@billbsu could you download the Insiders version of VSCode and check if it exhibits the same issue? Edit: how did you install VSCode via Flatpak or RPM? |
Vscode was installed via rpm. I just installed the insiders version. It behaves the same way. it stalls out 3 times (like the "program not responding") and then it finally loads. It is probably gonna freeze up and crash though. (will edit if it does) |
It did freeze indeed (i think when i tried opening a folder?) and here is the zip file |
@billbsu To answer one of your earlier questions ... when switching to integrated mode the nvidia devices do not appear on the pci bus. That is an effect of the linux kernel reducing power consumption from the nvidia chip. Hence, these lines do not appear in the
And that was the purpose of the change in 3.4.0 - cache the 01:00.0 value so a switch directly to nvidia mode can be made from integrated mode. Without it, you need to switch to hybrid mode first (so the pci bus id is available again) and then to nvidia mode. I do not see anything obvious in the logs either - except a few more lines of detail in main.log for the insiders edition:
Look at the last line. It suggests that at least one of the extensions is not happy. I think I would start disabling extensions until I found the culprit. Then, once identified, determine whether it is still compatible. Please make sure you followed the instructions at MS instructions to install the repo and then install vscode via dnf. This way all post-install scripts are assured to be executed. Note you may need to Uninstall the current version to get it to install correctly. OH! Note that #157 should not be considered a fix. It is just a proposed alternate approach to entering integrated mode that may work better in certain situations. But, please do try it when you get a chance when you have time. But, I really think the answer to your issue lies in VS Code somewhere and not envycontrol. Hope that helps. Let us know what you find. |
@billbsu - any progress? FYI - I needed to install the nvidia drivers from the Nvidia CUDA repo to help someone with pytorch and so I tested VS Code 1.88.0 (current stable) while I was at it. Absolutely no issues with those drivers either. Note I tested all 3 modes. |
VS code blank page is similar to black screen issue after login to latest CachyOS plasma 6 Wayland, when EnvyControl is in integrated mesa amdgpu. In latest daily build of Kubuntu 24.04, EnvyControl does not work, in 23.10 it works. |
I will have to investigate this, do you know if this also happens on Intel or is it only AMD? |
The black screen issue with mouse cursor after login is also on intel, but maybe not related to EnvyControl. Perhaps some Mesa, Kernel or initramfs bug. For example EnvyControl does not work automatically on CachyOS, i have to run:
|
Let me spin up a Kubuntu 24.04 to try |
@Miaua I couldn't reproduce the issue on my system running latest Kubuntu 24.04 and Nvidia 535 drivers on integrated mode. |
I was using default Nouveau and when I went to integrated mode the power draw was 25W, usually it's 7-8W. I will test the 535 driver. I have been using Nouveau in Kubuntu 23.10 and Fedora 39, because RTX 4060 can not be powered down when proprietary 535 or 550 driver is installed, but if you delete the file /usr/share/glvnd/egl_vendor.d/10_nvidia.json |
I don't see why integrated wouldn't work with nouveau since we're already blacklisting it |
Integrated mode has always worked rock solid with Nouveau. Weird thing is, i installed Kubuntu 24.04 daily build with proprietary Nvidia driver, but driver manager showed that Nouveau is installed. Better wait the 24.04 official release. Fedora 40 KDE daily worked perfectly with EnvyControl. |
I did notice that when I installed the 550.54.15 cuda driver on Fedora recently the installer did not blacklist noveau via I was not able to chase down why. But, there were lot's of mentions of "making sure things happen early enough in the boot process" in the stuff I read while doing research. FYI @bayasdev I'll look into a way to potentially blacklisting nouveau this way. I don't really like it, but ... I'll reach out to you separately to collect your thoughts and discuss design details. |
Describe the bug
In integrated mode, VS Code (Version 1.87.2) is just a blank page. Hybrid mode is fine and older version of VS Code works. Might just be something on VS Code's end but it seems that similar bugs happen due to graphical issues.
To Reproduce
Steps to reproduce the behavior:
sudo envycontrol -s integrated
code .
from the command lineExpected behavior
VS code boots normally
System Information:
The text was updated successfully, but these errors were encountered: