You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this intended? and/or what's the rationale behind this? I tried blaming the code and didn't find much :-/
IMHO, at the very least, I think that cp should use -P to NOT follow symlinks. And, while at it, it should use -R and not -r to avoid portability issues.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In
cc_external_rule_impl()
we have:https://github.com/bazelbuild/rules_foreign_cc/blob/9d5727d5e51bf1be8423dff7996bdb4d847b47e6/foreign_cc/private/framework.bzl#L415-L422
However,
copy_directory()
is, as its name indicates, (1) copying (NOT symlinking) the given directory and (2) the copy itself also DOES NOT preserve symlinks, because it's doingcp -L
(follow symlinks):https://github.com/bazelbuild/rules_foreign_cc/blob/9d5727d5e51bf1be8423dff7996bdb4d847b47e6/foreign_cc/private/framework/toolchains/linux_commands.bzl#L88-L92
Is this intended? and/or what's the rationale behind this? I tried blaming the code and didn't find much :-/
IMHO, at the very least, I think that
cp
should use-P
to NOT follow symlinks. And, while at it, it should use-R
and not-r
to avoid portability issues.Beta Was this translation helpful? Give feedback.
All reactions