Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto generation is not yet disabled in go.mods provided by go_deps in bzlmod #1736

Open
stefanpenner opened this issue Feb 15, 2024 · 0 comments · May be fixed by #1799 or #1888
Open

Proto generation is not yet disabled in go.mods provided by go_deps in bzlmod #1736

stefanpenner opened this issue Feb 15, 2024 · 0 comments · May be fixed by #1799 or #1888

Comments

@stefanpenner
Copy link
Contributor

What version of gazelle are you using?

Latest (0.35)

What version of rules_go are you using?

latest (0.44)

What version of Bazel are you using?

Latest (7.0.0)

Does this issue reproduce with the latest releases of all the above?

yes

What operating system and processor architecture are you using?

all

What did you do?

Add a go.mod which contains both .proto and .pb.go files, via go_deps.

What did you expect to see?

No protoc generation, generated BUILD files should reference the pb.go file.

What did you see instead?

When gazelle encounters .proto files it generates BUILD rules that compile the protos. This creates both a unexpected dependency on protoc, slower setup, and build experiences.

stefanpenner pushed a commit to stefanpenner/bazel-gazelle that referenced this issue May 7, 2024
stefanpenner added a commit to stefanpenner/bazel-gazelle that referenced this issue May 7, 2024
@TvdW TvdW linked a pull request Aug 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant