Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should correct test answers be defined? #174

Open
AshlinHarris opened this issue Aug 11, 2022 · 0 comments
Open

How should correct test answers be defined? #174

AshlinHarris opened this issue Aug 11, 2022 · 0 comments
Labels
question Further information is requested

Comments

@AshlinHarris
Copy link
Contributor

Generally, function outputs for PreprocessMD.jlare DataFrames.

For doctests, the expected output is simply the text displayed on the REPL when a DataFrame is printed. So, for this type of test, two strings are compared. In the unlikely event that DataFrames.jl changes how DataFrames are printed, the tests break, which might be the bestapproach.

In contrast, a few integration tests in test/runtests.jl compare outputs to the result of a DataFrame definition. For this type of test, a DataFrame is compared to a DataFrame. But most tests in this file compare strings, not DataFrames.

I prefer to compare DataFrames directly for integration tests, but most would need to be rewritten for this.

@AshlinHarris AshlinHarris added the question Further information is requested label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant