-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate historical data into A&R system #237
Comments
Cameron Pettit @JLWade Nope I think Recreation Services Team has done her part for now - there were some failed rows when migrating to dev that I assumed could be fixed before the migration to test/prod, so I sent those to Sally and she’s returned them to me ready to go - I’ve just been caught up with other stuff. I’m just getting back to this stuff now, integrating her changes as we speak. I’ll update the attached spreadsheet with Sally’s changes so we can use it as the master record of which data was used for our prod migrations (we don’t really care to save a record for dev/test). Once I’ve updated it I will kick off the migration to test so we can keep moving this along. Jessica Wade @cameronpettit thinking we can see if Sally can help us get some of the prep work done for this ticket - is there anything specific that needs to be done for the other historical data? Do we need sally’s eyes on the attached spreadsheet? Jessica Wade @janemoxd thats exactly what Cam suggested yesterday too :slight_smile: BRS-971: Migrate historical data from 2017-2019 into A&R system on TEST was cloned for that Jane Mountain Just adding a note here that a (possibly) sensible approach to this would be to import the data needed for variance triggers and validating by POs (last couple of years), get all of that set up and working first. Then later, we could import the older data that sounds like it won’t be used very much? Jessica Wade Before this can be done we need answers to: Jessica Wade even better! Cameron Pettit Yes, the new system should allow us to make new records for any point in history, we aren’t limited to the system launch day and afterwards. Adding a record (created by the new system) for missing data is something we can already do. Jessica Wade That makes sense - thank you! It would likely only be for missing data so sounds like we could figure something out. Cameron Pettit Our stance was to lock all legacy data on import. If I remember correctly, this is because the legacy data is too large/complex to verify that every single entry can be mapped to our new system. If we don’t differentiate that the legacy data was created by some system other than our own, it opens up a lot of potential for issues when we are trying to manipulate the data down the line. I’d be hesitant to allow any editing to historical records - because then it’s not a historical record anymore. If edits need to be made to a historical record, then a new record should be created with the new system, and then that historical record could be disposed. So theres ways to achieve what you’re asking, but I think we should steer clear of the ‘editing historical records’ path. Jessica Wade @cameronpettit can you refresh my memory - do these legacy records need to be “locked” upon import? I remember that being something we talked about - and if so, is there a way to unlock them in specific instances? |
Hearing that this would be a complex piece of work. |
October 11, 2024 prioritization session: A&R team identified this ticket/issue as something that can wait to be implemented (medium -priority). Linked to ticket 348 - Old data isn't showing export. |
This ticket no longer appears to be blocked. Given this is a high priority for A&R, thinking we can pull this one in and action. |
Standup notes:
|
This is ready to be deployed to TEST, @manuji! Once we're deployed to TEST, I'll run the migrations for the historical datasets and get all of the data from 2000 - 2016 into the TEST database. For testing, the data will have the same functionality as Let me know when you deploy and I'll get started on that right away 😄 |
Tested on TEST: Passed
|
Thank you @davidclaveau and to you @manuji for testing. I have not specifically tested and approve :) @sallyhaynes @nicolebottoms - FYI this is currently in TEST. |
Description
There are roughly 167,000 records to be brought over. We want to move away from the spreadsheet as the source of truth so it is important that this migration captures the spreadsheet in its entirety.
The migration will have to parse the spreadsheet on a row-by-row basis and create legacy record objects for each row. For some rows, new parks and subareas will also need to be created if they are not yet in the new system.
The record activity type (Frontcountry Camping, Day Use, etc) will have to be inferred from the populated columns in each row. Columns that do not fit into an existing activity type will be captured in a new activity,
Legacy Data
.Columns that belong into an existing activity type but do not exist within the new A&R system will be brought over as new legacy attributes in the migrated records. For example:
Net Revenue
totals are not saved in our new database, but are shown in historical data records. These historical totals should be captured in their own fields, eglegacy_frontcountryCampingPartiesNetRevenue
.Attached are spreadsheets containing field maps between new and historical data.
Handling legacy data in the FE and API will be handled in future tickets. The focus of this ticket is simply getting legacy data into the db.
Acceptance Criteria:
Legacy Data
created to capture columns that dont belong to an existing activityLegacy Data
- there will never be a case where this record will be empty.isLegacy: true
boolean and are locked.Notes
Legacy Data
object:Below is a finalized spreadsheet of mapped fields & legacy object models.
historical_data_comparison - Master.xlsx
Linked issues
blocks
BRS-972created by
BRS-680is blocked by
BRS-711BRS-971is cloned by
BRS-971The text was updated successfully, but these errors were encountered: