BRS-377-1: Fix Missing Export for "0" Data and Legacy Data; Fix Migration #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David <daveclaveau@gmail.com>
davidclaveau
requested review from
marklise,
danieltruong,
cameronpettit,
meredithom and
Christopher-walsh22
as code owners
cameronpettit
approved these changes
Dec 6, 2024
marklise
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
BRS-377
Ticket URL:
#377
Description:
Fixed an issue where we weren't checking if an item had a "0" input, which should have been flagged as "Missing Data" (#412)
Fixed a bug where empty notes were showing as
undefined(#413)Fix to data discrepancy migration - part of the function was wrongly nested, which led to a duplication of TransactionWrite operations for the same record, which led to batch errors
Also added logic to skip
isLegacy/(historical)dataAlso changed it so the Notes output is just a single column, which should improve readability
Even more comments, because comments are important!