remove valueGetterWith

bcgov · Feb 16, 2024 · 013b441 · 013b441
1 parent fd66dcc
commit 013b441
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 17 deletions.
diff --git a/web/src/features/moreCast2/components/ColumnDefBuilder.tsx b/web/src/features/moreCast2/components/ColumnDefBuilder.tsx
@@ -153,8 +153,6 @@ export class ColumnDefBuilder implements ColDefGenerator, ForecastColDefGenerato
 
   public valueFormatterWith = (params: Pick<GridValueFormatterParams, 'value'>, precision: number) =>
     this.gridComponentRenderer.predictionItemValueFormatter(params, precision)
-  public valueGetterWith = (params: Pick<GridValueGetterParams, 'value'>, precision: number) =>
-    this.gridComponentRenderer.cellValueGetter(params, precision)
   public valueGetter = (
     params: Pick<GridValueGetterParams, 'row' | 'value'>,
     field: string,

diff --git a/web/src/features/moreCast2/components/GridComponentRenderer.tsx b/web/src/features/moreCast2/components/GridComponentRenderer.tsx
@@ -153,8 +153,4 @@ export class GridComponentRenderer {
 
     return isNaN(value) ? params.value : value.toFixed(precision)
   }
-
-  public cellValueGetter = (params: Pick<GridValueGetterParams, 'value'>, precision: number) => {
-    return isNaN(params?.value) ? 'NaN' : params.value.toFixed(precision)
-  }
 }
diff --git a/web/src/features/moreCast2/components/colDefBuilder.test.tsx b/web/src/features/moreCast2/components/colDefBuilder.test.tsx
@@ -205,7 +205,6 @@ describe('ColDefBuilder', () => {
 
     it('should delegate to GridComponentRenderer', () => {
       expect(colDefBuilder.valueFormatterWith({ value: 1.11 }, 1)).toEqual('1.1')
-      expect(colDefBuilder.valueGetterWith({ value: 1.11 }, 1)).toEqual('1.1')
       expect(
         colDefBuilder.valueGetter(
           {

diff --git a/web/src/features/moreCast2/components/gridComponentRenderer.test.tsx b/web/src/features/moreCast2/components/gridComponentRenderer.test.tsx
@@ -182,16 +182,6 @@ describe('GridComponentRenderer', () => {
     expect(formattedItemValue).toEqual(NOT_REPORTING)
   })
 
-  it('should return an existent cell value correctly', () => {
-    const cellValue = gridComponentRenderer.cellValueGetter({ value: 1.11 }, 1)
-    expect(cellValue).toEqual('1.1')
-  })
-
-  it('should return an non-existent cell value correctly', () => {
-    const cellValue = gridComponentRenderer.cellValueGetter({ value: NaN }, 1)
-    expect(cellValue).toEqual('NaN')
-  })
-
   it('should return an existent prediction item value correctly', () => {
     const itemValue = gridComponentRenderer.valueGetter(
       {