Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup troubleshooting and poetry package additions #3111

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Setup troubleshooting and poetry package additions #3111

merged 5 commits into from
Sep 7, 2023

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Sep 7, 2023 •
edited by github-actions bot
Loading

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #3111 (b6f476f) into main (28b8d42) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   84.73%   84.74%   +0.01%     
==========================================
  Files         300      300              
  Lines       10118    10133      +15     
  Branches      591      591              
==========================================
+ Hits         8573     8587      +14     
- Misses       1383     1384       +1     
  Partials      162      162
Files Changed Coverage Δ
api/app/jobs/common_model_fetchers.py 80.89% <92.85%> (+0.65%) ⬆️
api/app/jobs/noaa.py 59.13% <100.00%> (+0.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@brettedw brettedw marked this pull request as ready for review September 7, 2023 18:59
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@brettedw brettedw requested review from conbrad and dgboss September 7, 2023 19:57
conbrad
conbrad approved these changes Sep 7, 2023
View reviewed changes
api/poetry.lock
@@ -1,4 +1,4 @@
# This file is automatically @generated by Poetry 1.5.1 and should not be changed by hand.
# This file is automatically @generated by Poetry 1.6.1 and should not be changed by hand.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your new machine setup grabbed the latest version of poetry to install, which is newer than what our base image has. Seems to install and run dependencies fine though but something to keep an eye on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, didn't notice that one

@brettedw brettedw temporarily deployed to production September 7, 2023 20:15 Inactive
@brettedw brettedw merged commit 8a3b035 into main Sep 7, 2023
31 checks passed
@brettedw brettedw deleted the task/setup-troubleshooting branch September 7, 2023 20:28
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@brettedw
Setup troubleshooting and poetry package additions (bcgov#3111)
7c4ae2b 
- Add some troubleshooting to api README
- Add greenlet to poetry managed dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conbrad conbrad conbrad approved these changes

@dgboss dgboss Awaiting requested review from dgboss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettedw @conbrad