Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single values from weather model rasters #3133

Merged
merged 12 commits into from
Oct 5, 2023
Merged

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Sep 22, 2023

  • Removes all grid lookup in favor of single lat,lon coordinate for station weather models
  • Adds net new model_run_predictions to store single values, leaving grid table untouched for now
  • Removes unused queries in weather_models module
  • Refactors bdd style tests for machine learning bias adjustments to use standard pytest tests

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #3133 (6312289) into main (4d5e3b6) will decrease coverage by 0.45%.
Report is 2 commits behind head on main.
The diff coverage is 55.12%.

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   84.71%   84.27%   -0.45%     
==========================================
  Files         301      301              
  Lines       10123    10113      -10     
  Branches      588      588              
==========================================
- Hits         8576     8523      -53     
- Misses       1384     1427      +43     
  Partials      163      163              
Files Coverage Δ
api/app/db/models/weather_models.py 97.36% <100.00%> (-0.68%) ⬇️
api/app/weather_models/machine_learning.py 89.83% <100.00%> (-2.97%) ⬇️
api/app/weather_models/__init__.py 93.65% <77.77%> (-3.32%) ⬇️
api/app/jobs/common_model_fetchers.py 58.13% <34.78%> (-22.76%) ⬇️
api/app/weather_models/process_grib.py 62.10% <40.00%> (-0.65%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conbrad conbrad requested a review from brettedw September 28, 2023 15:57
@conbrad conbrad marked this pull request as ready for review September 28, 2023 15:58
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@conbrad conbrad temporarily deployed to production October 5, 2023 17:41 Inactive
@conbrad conbrad merged commit 1458622 into main Oct 5, 2023
30 checks passed
@conbrad conbrad deleted the task/remove-grid-lookups branch October 5, 2023 17:59
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
- Removes all grid lookup in favor of single lat,lon coordinate for station weather models
- Adds net new `model_run_predictions` to store single values, leaving grid table untouched for now
- Removes unused queries in `weather_models` module
- Refactors bdd style tests for machine learning bias adjustments to use standard pytest tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants