Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90th Percentile Calculator - 2023 Update #3250

Merged
merged 16 commits into from
Nov 23, 2023
Merged

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Nov 20, 2023

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d260d42) 81.94% compared to head (ad394e5) 81.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3250   +/-   ##
=======================================
  Coverage   81.94%   81.95%           
=======================================
  Files         275      276    +1     
  Lines        9489     9496    +7     
  Branches      445      446    +1     
=======================================
+ Hits         7776     7782    +6     
- Misses       1594     1595    +1     
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conbrad
Copy link
Collaborator

conbrad commented Nov 21, 2023

Is there an easy way to filter out the stations that don't have data in the dropdown list? Currently the station list is populated from the WF1 stations, but for example station 1142 doesn't have any data.

@brettedw brettedw requested a review from dgboss November 21, 2023 20:03
api/scripts/station_csv_to_json.py Outdated Show resolved Hide resolved
api/scripts/station_csv_to_json.py Outdated Show resolved Hide resolved
@brettedw brettedw requested review from conbrad and dgboss November 22, 2023 20:48
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brettedw brettedw temporarily deployed to production November 22, 2023 23:49 Inactive
@brettedw brettedw merged commit d099424 into main Nov 23, 2023
32 checks passed
@brettedw brettedw deleted the task/percent-calc-2023 branch November 23, 2023 00:00
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
- Updates data to 2023
- Changes slider range to 30 years
- Adds warning if there is missing years for a station and time range selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

90th Percentile Calculator: Update Weather Data to End of 2023
3 participants