Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Pandas to v2 #3260

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Upgrade Pandas to v2 #3260

merged 2 commits into from
Nov 23, 2023

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Nov 23, 2023 •
edited
Loading

  • Only used in 90th Percentile scripts and fba-calc code
  • Modifications to 90th Percentile existing scripts to deal with warnings + make the code a bit more robust
  • No breaking changes in fba-calc
  • Closes Pandas v2: Upgrade #2800

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d260d42) 81.94% compared to head (cf9ae37) 81.95%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3260   +/-   ##
=======================================
  Coverage   81.94%   81.95%           
=======================================
  Files         275      276    +1     
  Lines        9489     9496    +7     
  Branches      445      446    +1     
=======================================
+ Hits         7776     7782    +6     
- Misses       1594     1595    +1     
  Partials      119      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested review from conbrad and dgboss November 23, 2023 21:09
conbrad
conbrad approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brettedw brettedw temporarily deployed to production November 23, 2023 23:39 Inactive
@brettedw brettedw merged commit b574ec3 into main Nov 23, 2023
32 checks passed
@brettedw brettedw deleted the task/pandas_v2 branch November 23, 2023 23:50
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@brettedw
Upgrade Pandas to v2 (bcgov#3260)
7035d4f 
Upgrades pandas to v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pandas v2: Upgrade
3 participants
@brettedw @conbrad @dgboss