Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoreCast - precip button move #3329

Merged
merged 1 commit into from
Jan 18, 2024
Merged

MoreCast - precip button move #3329

merged 1 commit into from
Jan 18, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Jan 18, 2024 •
edited by github-actions bot
Loading

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7631acd) 81.85% compared to head (7cc7673) 81.85%.

Files Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3329   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files         277      277           
  Lines        9563     9563           
  Branches      450      450           
=======================================
  Hits         7828     7828           
  Misses       1616     1616           
  Partials      119      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested review from conbrad and dgboss January 18, 2024 23:05
@brettedw brettedw temporarily deployed to production January 18, 2024 23:10 Inactive
@brettedw brettedw merged commit 6e5e871 into main Jan 18, 2024
31 checks passed
@brettedw brettedw deleted the task/morecast-precip-button branch January 18, 2024 23:19
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@brettedw
MoreCast - precip button move (bcgov#3329)
e0fdefa 
moves precip button the to end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgboss dgboss dgboss approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MoreCast: Move precipitation tab
3 participants
@brettedw @conbrad @dgboss