Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percent grass curing from CWFIS #3385

Merged
merged 14 commits into from
Feb 7, 2024
Merged

Percent grass curing from CWFIS #3385

merged 14 commits into from
Feb 7, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Feb 6, 2024 •
edited by github-actions bot
Loading

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (70d2469) 81.36% compared to head (012ef8f) 81.08%.

Files Patch % Lines
api/app/jobs/grass_curing.py 51.02% 48 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
- Coverage   81.36%   81.08%   -0.29%     
==========================================
  Files         278      280       +2     
  Lines        9696     9805     +109     
  Branches      454      454              
==========================================
+ Hits         7889     7950      +61     
- Misses       1685     1733      +48     
  Partials      122      122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

conbrad
conbrad approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

api/app/jobs/grass_curing.py Outdated Show resolved Hide resolved
api/app/jobs/grass_curing.py Outdated Show resolved Hide resolved
api/app/tests/jobs/test_grass_curing.py Outdated Show resolved Hide resolved
api/app/db/crud/grass_curing.py Outdated Show resolved Hide resolved
dgboss and others added 4 commits February 6, 2024 16:38
@dgboss @conbrad
Update api/app/db/crud/grass_curing.py
2ebfa10 
Co-authored-by: Conor Brady <con.brad@gmail.com>
@dgboss @conbrad
Update api/app/jobs/grass_curing.py
5a86e7b 
Co-authored-by: Conor Brady <con.brad@gmail.com>
@dgboss @conbrad
Update api/app/jobs/grass_curing.py
8e2e1cb 
Co-authored-by: Conor Brady <con.brad@gmail.com>
@dgboss @conbrad
Update api/app/tests/jobs/test_grass_curing.py
988a620 
Co-authored-by: Conor Brady <con.brad@gmail.com>
brettedw
brettedw approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgboss dgboss temporarily deployed to production February 7, 2024 17:36 Inactive
@dgboss dgboss merged commit c7eef9c into main Feb 7, 2024
30 checks passed
@dgboss dgboss deleted the task/grass-curing/3340 branch February 7, 2024 17:53
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
@dgboss @conbrad
Percent grass curing from CWFIS (bcgov#3385)
2bb2ee6 
Co-authored-by: Conor Brady <con.brad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettedw brettedw brettedw approved these changes

@conbrad conbrad conbrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgboss @conbrad @brettedw