-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show/Hide weather models #3402
Show/Hide weather models #3402
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
- Coverage 81.08% 80.99% -0.09%
==========================================
Files 280 281 +1
Lines 9805 9933 +128
Branches 454 473 +19
==========================================
+ Hits 7950 8045 +95
- Misses 1733 1760 +27
- Partials 122 128 +6 ☔ View full report in Codecov by Sentry. |
It's looking great! Looks like there might be a couple small bugs I came across
|
Thanks for taking a look! WRT double-clicking, my branch is likely stale. I'll update and test. I'll look into the forecast column bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, do you think we should start some test coverage around some of this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just commenting again to +1 Brett's findings, and wondering if we can test some of this stuff, maybe around the forecast column issue.
Yep, the double-click was due to a stale branch. Updated and all good now. |
Got the disappearing forecast bug resovled. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR allows a user to select which weather model columns they would like to display for each weather parameter. Selections are save to local storage and restored when the app is re-opened with the same browser on the same computer.
Test Links:
Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator