Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide weather models #3402

Merged
merged 10 commits into from
Feb 14, 2024
Merged

Show/Hide weather models #3402

merged 10 commits into from
Feb 14, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Feb 13, 2024

This PR allows a user to select which weather model columns they would like to display for each weather parameter. Selections are save to local storage and restored when the app is re-opened with the same browser on the same computer.

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (df91b76) 81.08% compared to head (8b91498) 80.99%.

Files Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 79.56% 11 Missing and 8 partials ⚠️
.../features/moreCast2/components/DataGridColumns.tsx 60.71% 10 Missing and 1 partial ⚠️
.../src/features/moreCast2/components/GroupHeader.tsx 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3402      +/-   ##
==========================================
- Coverage   81.08%   80.99%   -0.09%     
==========================================
  Files         280      281       +1     
  Lines        9805     9933     +128     
  Branches      454      473      +19     
==========================================
+ Hits         7950     8045      +95     
- Misses       1733     1760      +27     
- Partials      122      128       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw
Copy link
Collaborator

It's looking great! Looks like there might be a couple small bugs I came across

  • cell double clicking seems to be broken again...seems annoyingly fragile
  • If you turn off all the tab groups, then turn one back on, you lose the Forecast column

@dgboss
Copy link
Collaborator Author

dgboss commented Feb 13, 2024

It's looking great! Looks like there might be a couple small bugs I came across

  • cell double clicking seems to be broken again...seems annoyingly fragile
  • If you turn off all the tab groups, then turn one back on, you lose the Forecast column

Thanks for taking a look!

WRT double-clicking, my branch is likely stale. I'll update and test.

I'll look into the forecast column bug.

Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, do you think we should start some test coverage around some of this code?

@conbrad conbrad self-requested a review February 13, 2024 18:27
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just commenting again to +1 Brett's findings, and wondering if we can test some of this stuff, maybe around the forecast column issue.

@dgboss
Copy link
Collaborator Author

dgboss commented Feb 13, 2024

MoreCast 2.0

Yep, the double-click was due to a stale branch. Updated and all good now.

@dgboss
Copy link
Collaborator Author

dgboss commented Feb 14, 2024

Got the disappearing forecast bug resovled.

@dgboss dgboss requested a review from brettedw February 14, 2024 17:02
@dgboss dgboss requested a review from rajpersram February 14, 2024 17:16
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dgboss dgboss temporarily deployed to production February 14, 2024 18:21 Inactive
@dgboss dgboss merged commit ac14d0c into main Feb 14, 2024
28 checks passed
@dgboss dgboss deleted the task/show-hide-columns/3214 branch February 14, 2024 19:04
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants