Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoreCast: Forecast - Actual split #3415

Merged
merged 26 commits into from
Feb 16, 2024
Merged

MoreCast: Forecast - Actual split #3415

merged 26 commits into from
Feb 16, 2024

Conversation

brettedw
Copy link
Collaborator

@brettedw brettedw commented Feb 15, 2024

-splits out forecast and actual columns
-removes N/A for forecast-able cells
-disables cells for previous dates
-No 'Actual' label in Actual column

closes #3394

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c8235e8) 80.99% compared to head (087e887) 81.01%.

Files Patch % Lines
...c/features/moreCast2/components/TabbedDataGrid.tsx 0.00% 2 Missing ⚠️
...features/moreCast2/components/ColumnDefBuilder.tsx 92.85% 1 Missing ⚠️
...res/moreCast2/components/GridComponentRenderer.tsx 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3415      +/-   ##
==========================================
+ Coverage   80.99%   81.01%   +0.02%     
==========================================
  Files         281      281              
  Lines        9933     9957      +24     
  Branches      473      480       +7     
==========================================
+ Hits         8045     8067      +22     
- Misses       1760     1763       +3     
+ Partials      128      127       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettedw brettedw requested review from conbrad and dgboss February 16, 2024 01:09
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@brettedw brettedw temporarily deployed to production February 16, 2024 17:16 Inactive
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@brettedw brettedw temporarily deployed to production February 16, 2024 19:19 Inactive
@brettedw brettedw merged commit fe6eaf8 into main Feb 16, 2024
28 checks passed
@brettedw brettedw deleted the task/forecast-actual-split branch February 16, 2024 19:33
brettedw added a commit that referenced this pull request Feb 16, 2024
Fixes Morecast double click exception introduced in #3415
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
-splits out forecast and actual columns
-removes N/A for forecast-able cells
-disables cells for previous dates
-No 'Actual' label in Actual column

closes bcgov#3394
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Fixes Morecast double click exception introduced in bcgov#3415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MoreCast 2.0: Implement forecast & actual column changes
2 participants