Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel type distribution #3792

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Fuel type distribution #3792

merged 9 commits into from
Jul 23, 2024

Conversation

dgboss
Copy link
Collaborator

@dgboss dgboss commented Jul 19, 2024

Adds a basic fuel type description component that contains:

  • fuel type code with tool tip containing description of the fuel type
  • a horizontal bar indicating the percent contribution of the fuel type to the overall high HFI (>4,000) area
  • tweaked some subtitles in the side panel

This PR does not include the critical hours or the ability to select fuel types.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (a9763ac) to head (0974242).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3792   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files         297      297           
  Lines       10882    10882           
  Branches      525      525           
=======================================
  Hits         8637     8637           
  Misses       2100     2100           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgboss dgboss requested review from conbrad and brettedw July 22, 2024 20:18
web/src/features/fba/components/viz/ElevationInfoViz.tsx Outdated Show resolved Hide resolved
web/src/features/fba/components/viz/FuelSummary.tsx Outdated Show resolved Hide resolved
web/src/features/fba/components/viz/FuelSummary.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks fantastic

web/src/features/fba/components/viz/FuelSummary.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 22, 2024

@dgboss dgboss temporarily deployed to production July 23, 2024 15:14 Inactive
@dgboss dgboss merged commit 1e4c328 into main Jul 23, 2024
29 checks passed
@dgboss dgboss deleted the task/fuel-type-distribution/3745 branch July 23, 2024 15:28
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants