Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeploy SFMS #3828

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Undeploy SFMS #3828

merged 1 commit into from
Aug 8, 2024

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Aug 8, 2024

Undoes changes from #3623

No longer need to separate SFMS code as a service.
Some minor ruff autoformatting and cspell additions.

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link

sonarcloud bot commented Aug 8, 2024

@conbrad conbrad requested review from dgboss and brettedw August 8, 2024 21:06
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (3ab289e) to head (cebcada).

Files Patch % Lines
api/app/routers/sfms.py 65.85% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3828      +/-   ##
==========================================
+ Coverage   79.35%   79.59%   +0.24%     
==========================================
  Files         295      294       -1     
  Lines       10862    10823      -39     
  Branches      518      518              
==========================================
- Hits         8619     8615       -4     
+ Misses       2099     2064      -35     
  Partials      144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conbrad conbrad temporarily deployed to production August 8, 2024 22:05 Inactive
@conbrad conbrad merged commit 2467550 into main Aug 8, 2024
28 checks passed
@conbrad conbrad deleted the task/undeploy-sfms branch August 8, 2024 22:17
dgboss pushed a commit that referenced this pull request Aug 14, 2024
Undoes changes from #3623

No longer need to separate SFMS code as a service.
Some minor ruff autoformatting and cspell additions.
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Undoes changes from bcgov#3623

No longer need to separate SFMS code as a service.
Some minor ruff autoformatting and cspell additions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants