Use urllib encode to encode pg pass #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3839 +/- ##
=======================================
Coverage 79.31% 79.31%
=======================================
Files 295 295
Lines 10874 10874
Branches 518 518
=======================================
Hits 8625 8625
Misses 2105 2105
Partials 144 144 ☔ View full report in Codecov by Sentry. |
|
dgboss
approved these changes
Aug 12, 2024
brettedw
approved these changes
Aug 12, 2024
dgboss
pushed a commit
that referenced
this pull request
Aug 14, 2024
CrunchyDB generates password with special characters that end up being used in connection strings, this PR encodes them using https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote Also adjusts the connection string referenced by alembic to escape `%` with `%%`. Pieced this together from issues here: sqlalchemy/alembic#1280 and here: mlflow/mlflow#1487
vanislekahuna
pushed a commit
to vanislekahuna/wps
that referenced
this pull request
Sep 19, 2024
CrunchyDB generates password with special characters that end up being used in connection strings, this PR encodes them using https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote Also adjusts the connection string referenced by alembic to escape `%` with `%%`. Pieced this together from issues here: sqlalchemy/alembic#1280 and here: mlflow/mlflow#1487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrunchyDB generates password with special characters that end up being used in connection strings, this PR encodes them using https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote
Also adjusts the connection string referenced by alembic to escape
%with%%. Pieced this together from issues here: sqlalchemy/alembic#1280 and here: mlflow/mlflow#1487Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator