frontend to vite #3860
frontend to vite #3860
Conversation
Nice! How many tests are disabled? The code coverage reports make sense when I'm looking at the ones with coverage or partial coverage, but a bunch of missing coverage around HFI Calculator signals that either those cypress tests are disabled or the coverage report isn't being merged properly. |
whoops!
|
There was a problem hiding this comment.
Looks great, amazing work thanks for the considerable amount of effort that went into this! Builds are faster and we can sever our dependency on cra.
On my side just the couple comments I added this morning to be resolved, and the injected error to test sentry source maps and I'm happy. I'll let @dgboss and @brettedw carve out some time to review further.
| @@ -14,16 +14,6 @@ const store = configureStore({ | |||
| getDefaultMiddleware({ immutableCheck: false, serializableCheck: false }).concat(thunkMiddleware) | |||
| }) | |||
|
|
|||
| if (process.env.NODE_ENV === 'development' && module.hot) { | |||
There was a problem hiding this comment.
Do you know if we get the equivalent behaviour with vite out of the box? Or will we have to re-start our debugging session if we are making changes to a reducer?
There was a problem hiding this comment.
hmmm. I feel like vite should handle this well since a big focus of it is not having to rebundle stuff https://vitejs.dev/guide/why.html#why-vite . But i haven't done much reducer stuff lately. Can you break down for me what problem this was solving? you don't want to lose some state in redux?
There was a problem hiding this comment.
I was curious more than anything so not a big deal. I think you are correct in that it prevented loss of state in redux. I don't think we need to do anything or look into this any further. Thanks!
|
Things I did
Outcomes
closes Migrate frontend build to vite #3785
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator